Bug 196334

Summary: JetStream 2 should not report time values as scores
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, commit-queue, ews-watchlist, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, rniwa, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2019-03-27 18:03:11 PDT
...
Attachments
patch (3.28 KB, patch)
2019-03-27 18:14 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-03-27 18:14:28 PDT
Created attachment 366138 [details] patch
Yusuke Suzuki
Comment 2 2019-03-27 18:21:22 PDT
Comment on attachment 366138 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=366138&action=review r=me > Websites/browserbench.org/JetStream2.0/JetStreamDriver.js:324 > const subTimes = benchmark.subTimes(); subTimes return scores, it is a bit tricky. But it seems that all the XXXTimes in benchmarks now uses score (toScore()). So I think we should rename these variables and methods at some point to reflect that this is a score.
WebKit Commit Bot
Comment 3 2019-03-27 18:47:34 PDT
Comment on attachment 366138 [details] patch Clearing flags on attachment: 366138 Committed r243597: <https://trac.webkit.org/changeset/243597>
WebKit Commit Bot
Comment 4 2019-03-27 18:47:36 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-03-27 18:48:16 PDT
<rdar://problem/49363811>
Note You need to log in before you can comment on or make changes to this bug.