| Summary: | JetStream 2 should not report time values as scores | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, cdumez, commit-queue, ews-watchlist, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, rniwa, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Saam Barati
2019-03-27 18:03:11 PDT
Created attachment 366138 [details]
patch
Comment on attachment 366138 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=366138&action=review r=me > Websites/browserbench.org/JetStream2.0/JetStreamDriver.js:324 > const subTimes = benchmark.subTimes(); subTimes return scores, it is a bit tricky. But it seems that all the XXXTimes in benchmarks now uses score (toScore()). So I think we should rename these variables and methods at some point to reflect that this is a score. Comment on attachment 366138 [details] patch Clearing flags on attachment: 366138 Committed r243597: <https://trac.webkit.org/changeset/243597> All reviewed patches have been landed. Closing bug. |