Bug 196334 - JetStream 2 should not report time values as scores
Summary: JetStream 2 should not report time values as scores
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
Keywords: InRadar
Depends on:
Reported: 2019-03-27 18:03 PDT by Saam Barati
Modified: 2019-03-27 18:48 PDT (History)
17 users (show)

See Also:

patch (3.28 KB, patch)
2019-03-27 18:14 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-03-27 18:03:11 PDT
Comment 1 Saam Barati 2019-03-27 18:14:28 PDT
Created attachment 366138 [details]
Comment 2 Yusuke Suzuki 2019-03-27 18:21:22 PDT
Comment on attachment 366138 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=366138&action=review


> Websites/browserbench.org/JetStream2.0/JetStreamDriver.js:324
>              const subTimes = benchmark.subTimes();

subTimes return scores, it is a bit tricky. But it seems that all the XXXTimes in benchmarks now uses score (toScore()).
So I think we should rename these variables and methods at some point to reflect that this is a score.
Comment 3 WebKit Commit Bot 2019-03-27 18:47:34 PDT
Comment on attachment 366138 [details]

Clearing flags on attachment: 366138

Committed r243597: <https://trac.webkit.org/changeset/243597>
Comment 4 WebKit Commit Bot 2019-03-27 18:47:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-03-27 18:48:16 PDT