Summary: | [ews-app] Update display text of Submit for ews analysis | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, dewei_zhu, jbedard, lforschler, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Created attachment 366094 [details]
Patch
Comment on attachment 366094 [details]
Patch
After we replace the old EWS with the new EWS, are we going to go back and update these strings to take out "new" ?
> After we replace the old EWS with the new EWS, are we going to go back and update these strings to take out "new" ?
Yes, that's the plan.
Comment on attachment 366094 [details] Patch Clearing flags on attachment: 366094 Committed r243564: <https://trac.webkit.org/changeset/243564> All reviewed patches have been landed. Closing bug. |
Created attachment 366093 [details] Screenshot The new EWS and current EWS, both displays the same button for 'Submit for EWS Analysis'. On a bug without r? (and in many other cases), both these button will show up. It might be confusing to see two button with exact same text (screenshot attached). So, we should update the display text of this button for new EWS.