RESOLVED FIXED 196309
[ews-app] Update display text of Submit for ews analysis 
https://bugs.webkit.org/show_bug.cgi?id=196309
Summary [ews-app] Update display text of Submit for ews analysis
Aakash Jain
Reported 2019-03-27 12:32:38 PDT
Created attachment 366093 [details] Screenshot The new EWS and current EWS, both displays the same button for 'Submit for EWS Analysis'. On a bug without r? (and in many other cases), both these button will show up. It might be confusing to see two button with exact same text (screenshot attached). So, we should update the display text of this button for new EWS.
Attachments
Screenshot (38.82 KB, image/png)
2019-03-27 12:32 PDT, Aakash Jain 		no flags
Details
Patch (1.31 KB, patch)
2019-03-27 12:33 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-03-27 12:33:32 PDT
Created attachment 366094 [details] Patch
Lucas Forschler
Comment 2 2019-03-27 13:58:53 PDT
Comment on attachment 366094 [details] Patch After we replace the old EWS with the new EWS, are we going to go back and update these strings to take out "new" ?
Aakash Jain
Comment 3 2019-03-27 14:06:30 PDT
> After we replace the old EWS with the new EWS, are we going to go back and update these strings to take out "new" ? Yes, that's the plan.
WebKit Commit Bot
Comment 4 2019-03-27 14:09:50 PDT
Comment on attachment 366094 [details] Patch Clearing flags on attachment: 366094 Committed r243564: <https://trac.webkit.org/changeset/243564>
WebKit Commit Bot
Comment 5 2019-03-27 14:09:51 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-03-27 14:10:43 PDT
<rdar://problem/49352562>
Note You need to log in before you can comment on or make changes to this bug.