Bug 196309 - [ews-app] Update display text of Submit for ews analysis
Summary: [ews-app] Update display text of Submit for ews analysis
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-27 12:32 PDT by Aakash Jain
Modified: 2019-03-27 14:10 PDT (History)
7 users (show)

See Also:

Attachments
Screenshot (38.82 KB, image/png)
2019-03-27 12:32 PDT, Aakash Jain 		no flags Details
Patch (1.31 KB, patch)
2019-03-27 12:33 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-03-27 12:32:38 PDT 
Created attachment 366093 [details]
Screenshot

The new EWS and current EWS, both displays the same button for 'Submit for EWS Analysis'. On a bug without r? (and in many other cases), both these button will show up. It might be confusing to see two button with exact same text (screenshot attached). So, we should update the display text of this button for new EWS.
Comment 1 Aakash Jain 2019-03-27 12:33:32 PDT 
Created attachment 366094 [details]
Patch
Comment 2 Lucas Forschler 2019-03-27 13:58:53 PDT 
Comment on attachment 366094 [details]
Patch

After we replace the old EWS with the new EWS, are we going to go back and update these strings to take out "new" ?
Comment 3 Aakash Jain 2019-03-27 14:06:30 PDT 
> After we replace the old EWS with the new EWS, are we going to go back and update these strings to take out "new" ?
Yes, that's the plan.
Comment 4 WebKit Commit Bot 2019-03-27 14:09:50 PDT 
Comment on attachment 366094 [details]
Patch

Clearing flags on attachment: 366094

Committed r243564: <https://trac.webkit.org/changeset/243564>
Comment 5 WebKit Commit Bot 2019-03-27 14:09:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-03-27 14:10:43 PDT 
<rdar://problem/49352562>