| Summary: | Add another status-bubble iframe to display results from new EWS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, dean_johnson, jbedard, kocsen_chung, lforschler, lingho, ryanhaddad, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=209215 | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2019-03-27 11:59:56 PDT
Created attachment 366089 [details]
Patch
To be clear, this adds another row of bubbles, right? Also, the intention of this is to eventually remove the current row once we've migrated everything to new EWS, right? (In reply to Jonathan Bedard from comment #2) > To be clear, this adds another row of bubbles, right? It adds more bubbles in same row. Two iframes are aligned horizontally. e.g.: https://bugs.webkit-uat.org/show_bug.cgi?id=168329 > > Also, the intention of this is to eventually remove the current row once we've migrated everything to new EWS, right? Yes. Comment on attachment 366089 [details] Patch is there any easy way to pull our these URLs into a constant variable and reference that in the code? If we ever change the url, it would make it much easier to update. I think we should consider this for both https://ews.webkit.org and webkit-queues.webkit.org. > is there any easy way to pull our these URLs into a constant variable and reference that in the code? If we ever change the url, it would make it much easier to update.
Don't see an easy way. Will probably attempt that in a separate patch later.
Also going to fix some UI glitches by setting the initial width of iframe to 0px instead of 600px.
Committed r243921: <https://trac.webkit.org/changeset/243921> |