| Summary: | Fix some more deprecation warnings in WKDrawingView | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bdakin, commit-queue, dino, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2019-03-26 18:08:04 PDT
Created attachment 366032 [details]
Patch
Comment on attachment 366032 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366032&action=review > Source/WebKit/UIProcess/ios/WKDrawingCoordinator.mm:35 > +#import <WebKitAdditions/WKDrawingCoordinatorAdditions.mm> Nit - may consider a #if USE(APPLE_INTERNAL_SDK) here, though it's probably not necessary since HAVE(PENCILKIT) is off in all non-internal SDKs, and probably by the time that's no longer the case you would've already moved the code into open source :) Comment on attachment 366032 [details] Patch Clearing flags on attachment: 366032 Committed r243553: <https://trac.webkit.org/changeset/243553> All reviewed patches have been landed. Closing bug. |