Bug 196270

Summary: [ews-build] Use PostgreSQL for ews.webkit.org database
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch lforschler: review+

Description Aakash Jain 2019-03-26 13:45:39 PDT
Use PostgreSQL for ews.webkit.org database since it's much better than the default sqlite.
Comment 1 Aakash Jain 2019-03-26 13:46:22 PDT
Created attachment 365995 [details]
Patch
Comment 2 Lucas Forschler 2019-03-26 13:52:45 PDT
Comment on attachment 365995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365995&action=review

r+ with assignment fix.

> Tools/BuildSlaveSupport/ews-app/ews-app/settings.py:115
> +        }

these are mis-aligned by one char.
if we are leaving PORT as empty, do we need to include it at all?
Comment 3 Aakash Jain 2019-03-26 14:03:51 PDT
Comment on attachment 365995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365995&action=review

>> Tools/BuildSlaveSupport/ews-app/ews-app/settings.py:115
>> +        }
> 
> these are mis-aligned by one char.
> if we are leaving PORT as empty, do we need to include it at all?

Will fix the alignment. 
PORT defaults to empty: https://docs.djangoproject.com/en/1.11/ref/settings/#port So, we can remove the PORT.
Comment 4 Aakash Jain 2019-03-26 14:04:56 PDT
Committed r243518: <https://trac.webkit.org/changeset/243518>
Comment 5 Radar WebKit Bug Importer 2019-03-26 14:07:29 PDT
<rdar://problem/49290738>