Bug 196267

Summary: Implement async paste method on UIWKInteractionViewProtocol
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch for landing none

Description Wenson Hsieh 2019-03-26 13:07:39 PDT
<rdar://problem/49236346>
Comment 1 Wenson Hsieh 2019-03-26 13:16:30 PDT
Created attachment 365991 [details]
Patch
Comment 2 Tim Horton 2019-03-26 13:19:51 PDT
Comment on attachment 365991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365991&action=review

> Tools/TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:151
> +    [UIPasteboard generalPasteboard].URLs = @[[NSURL URLWithString:@"https://www.apple.com/"]];

@[ [thing thing] ];?
Comment 3 Wenson Hsieh 2019-03-26 13:22:49 PDT
(In reply to Tim Horton from comment #2)
> Comment on attachment 365991 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=365991&action=review
> 
> > Tools/TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:151
> > +    [UIPasteboard generalPasteboard].URLs = @[[NSURL URLWithString:@"https://www.apple.com/"]];
> 
> @[ [thing thing] ];?

The linter seems to complain about spaces around a capture block when I do this (I think it thinks it's a C++ lambda :/)

In any case, I changed this to just be ….URL = [NSURL …];
Comment 4 Wenson Hsieh 2019-03-26 13:36:53 PDT
Created attachment 365994 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-03-26 14:15:22 PDT
Comment on attachment 365994 [details]
Patch for landing

Clearing flags on attachment: 365994

Committed r243519: <https://trac.webkit.org/changeset/243519>