Bug 196259

Summary:

[ContentChangeObserver] Skip anonymous renderers when checking for "willRespondToMouseClickEvents"

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, dino, simon.fraser, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2019-03-26 09:50:55 PDT

they don't count.

Comment 1 zalan 2019-03-26 09:51:10 PDT

<rdar://problem/49240029>

Comment 2 zalan 2019-03-26 09:55:10 PDT

Created attachment 365971 [details]
Patch

Comment 3 Dean Jackson 2019-03-26 10:00:44 PDT

Comment on attachment 365971 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365971&action=review

> LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html:32
> +    let rect = tapthis.getBoundingClientRect();
> +    let x = rect.left + rect.width / 2;
> +    let y = rect.top + rect.height / 2;

can use const :)

Comment 4 zalan 2019-03-26 10:03:35 PDT

(In reply to Dean Jackson from comment #3)
> Comment on attachment 365971 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=365971&action=review
> 
> > LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html:32
> > +    let rect = tapthis.getBoundingClientRect();
> > +    let x = rect.left + rect.width / 2;
> > +    let y = rect.top + rect.height / 2;
> 
> can use const :)
Oh I didn't know about it!

Comment 5 WebKit Commit Bot 2019-03-26 10:27:11 PDT

Comment on attachment 365971 [details]
Patch

Clearing flags on attachment: 365971

Committed r243503: <https://trac.webkit.org/changeset/243503>

Comment 6 WebKit Commit Bot 2019-03-26 10:27:12 PDT

All reviewed patches have been landed.  Closing bug.