RESOLVED FIXED 196259
[ContentChangeObserver] Skip anonymous renderers when checking for "willRespondToMouseClickEvents" 
https://bugs.webkit.org/show_bug.cgi?id=196259
Summary [ContentChangeObserver] Skip anonymous renderers when checking for "willRespo...
alan
Reported 2019-03-26 09:50:55 PDT
they don't count.
Attachments
Patch (4.90 KB, patch)
2019-03-26 09:55 PDT, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2019-03-26 09:51:10 PDT
<rdar://problem/49240029>
alan
Comment 2 2019-03-26 09:55:10 PDT
Created attachment 365971 [details] Patch
Dean Jackson
Comment 3 2019-03-26 10:00:44 PDT
Comment on attachment 365971 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365971&action=review > LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html:32 > + let rect = tapthis.getBoundingClientRect(); > + let x = rect.left + rect.width / 2; > + let y = rect.top + rect.height / 2; can use const :)
alan
Comment 4 2019-03-26 10:03:35 PDT
(In reply to Dean Jackson from comment #3) > Comment on attachment 365971 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=365971&action=review > > > LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html:32 > > + let rect = tapthis.getBoundingClientRect(); > > + let x = rect.left + rect.width / 2; > > + let y = rect.top + rect.height / 2; > > can use const :) Oh I didn't know about it!
WebKit Commit Bot
Comment 5 2019-03-26 10:27:11 PDT
Comment on attachment 365971 [details] Patch Clearing flags on attachment: 365971 Committed r243503: <https://trac.webkit.org/changeset/243503>
WebKit Commit Bot
Comment 6 2019-03-26 10:27:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.