Bug 196259 - [ContentChangeObserver] Skip anonymous renderers when checking for "willRespondToMouseClickEvents"
Summary: [ContentChangeObserver] Skip anonymous renderers when checking for "willRespo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-26 09:50 PDT by zalan
Modified: 2019-03-26 10:27 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.90 KB, patch)
2019-03-26 09:55 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-03-26 09:50:55 PDT 
they don't count.
Comment 1 zalan 2019-03-26 09:51:10 PDT 
<rdar://problem/49240029>
Comment 2 zalan 2019-03-26 09:55:10 PDT 
Created attachment 365971 [details]
Patch
Comment 3 Dean Jackson 2019-03-26 10:00:44 PDT 
Comment on attachment 365971 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365971&action=review

> LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html:32
> +    let rect = tapthis.getBoundingClientRect();
> +    let x = rect.left + rect.width / 2;
> +    let y = rect.top + rect.height / 2;

can use const :)
Comment 4 zalan 2019-03-26 10:03:35 PDT 
(In reply to Dean Jackson from comment #3)
> Comment on attachment 365971 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=365971&action=review
> 
> > LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html:32
> > +    let rect = tapthis.getBoundingClientRect();
> > +    let x = rect.left + rect.width / 2;
> > +    let y = rect.top + rect.height / 2;
> 
> can use const :)
Oh I didn't know about it!
Comment 5 WebKit Commit Bot 2019-03-26 10:27:11 PDT 
Comment on attachment 365971 [details]
Patch

Clearing flags on attachment: 365971

Committed r243503: <https://trac.webkit.org/changeset/243503>
Comment 6 WebKit Commit Bot 2019-03-26 10:27:12 PDT 
All reviewed patches have been landed.  Closing bug.