Bug 196244

Summary: [GStreamer] Remove the HLS queue buffering query hack
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: MediaAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch calvaris: review+

Philippe Normand
Reported 2019-03-26 02:40:52 PDT
.
Attachments
Patch (7.49 KB, patch)
2019-03-26 04:35 PDT, Philippe Normand 		calvaris: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2019-03-26 04:35:24 PDT
Created attachment 365959 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2019-03-27 00:44:43 PDT
Comment on attachment 365959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365959&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1592 > + gst_query_parse_buffering_range(query.get(), nullptr, nullptr, &stop, nullptr); Would it make sense to get the format and ASSERT it is PERCENT?
Philippe Normand
Comment 3 2019-03-27 04:30:28 PDT
Comment on attachment 365959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365959&action=review >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1592 >> + gst_query_parse_buffering_range(query.get(), nullptr, nullptr, &stop, nullptr); > > Would it make sense to get the format and ASSERT it is PERCENT? Sure, why not :)
Philippe Normand
Comment 4 2019-03-27 04:35:12 PDT
Committed r243537: <https://trac.webkit.org/changeset/243537>
Radar WebKit Bug Importer
Comment 5 2019-03-27 04:41:08 PDT
<rdar://problem/49327622>
Note You need to log in before you can comment on or make changes to this bug.