| Summary: | [GStreamer] Remove the HLS queue buffering query hack | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
| Component: | Media | Assignee: | Philippe Normand <pnormand> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | calvaris, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Philippe Normand
2019-03-26 02:40:52 PDT
Created attachment 365959 [details]
Patch
Comment on attachment 365959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365959&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1592 > + gst_query_parse_buffering_range(query.get(), nullptr, nullptr, &stop, nullptr); Would it make sense to get the format and ASSERT it is PERCENT? Comment on attachment 365959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365959&action=review >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1592 >> + gst_query_parse_buffering_range(query.get(), nullptr, nullptr, &stop, nullptr); > > Would it make sense to get the format and ASSERT it is PERCENT? Sure, why not :) Committed r243537: <https://trac.webkit.org/changeset/243537> |