Bug 196244 - [GStreamer] Remove the HLS queue buffering query hack
Summary: [GStreamer] Remove the HLS queue buffering query hack
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-26 02:40 PDT by Philippe Normand
Modified: 2019-03-27 04:41 PDT (History)
2 users (show)

See Also:


Attachments
Patch (7.49 KB, patch)
2019-03-26 04:35 PDT, Philippe Normand
calvaris: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2019-03-26 02:40:52 PDT
.
Comment 1 Philippe Normand 2019-03-26 04:35:24 PDT
Created attachment 365959 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2019-03-27 00:44:43 PDT
Comment on attachment 365959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365959&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1592
> +        gst_query_parse_buffering_range(query.get(), nullptr, nullptr, &stop, nullptr);

Would it make sense to get the format and ASSERT it is PERCENT?
Comment 3 Philippe Normand 2019-03-27 04:30:28 PDT
Comment on attachment 365959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365959&action=review

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1592
>> +        gst_query_parse_buffering_range(query.get(), nullptr, nullptr, &stop, nullptr);
> 
> Would it make sense to get the format and ASSERT it is PERCENT?

Sure, why not :)
Comment 4 Philippe Normand 2019-03-27 04:35:12 PDT
Committed r243537: <https://trac.webkit.org/changeset/243537>
Comment 5 Radar WebKit Bug Importer 2019-03-27 04:41:08 PDT
<rdar://problem/49327622>