Bug 196231

Summary: Web Inspector: DOMDebugger: move breakpoint storage to use `WI.ObjectStore`
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=192719
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2019-03-25 16:58:00 PDT
Rather than having to `JSON.stringify` and `JSON.parse` each breakpoint in a giant list on `localStorage`, we can leverage IndexedDB to store breakpoints in a more "friendly" way. Additionally, this would allow us to not have to re-serialize all breakpoints when saving an update to a single breakpoint.
Attachments
Patch (16.59 KB, patch)
2019-03-25 17:22 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-03-25 17:03:32 PDT
<rdar://problem/49236864>
Devin Rousso
Comment 2 2019-03-25 17:22:29 PDT
Created attachment 365924 [details] Patch
Joseph Pecoraro
Comment 3 2019-04-15 11:35:44 PDT
Comment on attachment 365924 [details] Patch r=me, nice!
WebKit Commit Bot
Comment 4 2019-04-15 12:17:19 PDT
Comment on attachment 365924 [details] Patch Clearing flags on attachment: 365924 Committed r244279: <https://trac.webkit.org/changeset/244279>
WebKit Commit Bot
Comment 5 2019-04-15 12:17:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.