Bug 196231

Summary:

Web Inspector: DOMDebugger: move breakpoint storage to use `WI.ObjectStore`

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=192719

Attachments:

Description	Flags
Patch	none

Description Devin Rousso 2019-03-25 16:58:00 PDT

Rather than having to `JSON.stringify` and `JSON.parse` each breakpoint in a giant list on `localStorage`, we can leverage IndexedDB to store breakpoints in a more "friendly" way.  Additionally, this would allow us to not have to re-serialize all breakpoints when saving an update to a single breakpoint.

Comment 1 Radar WebKit Bug Importer 2019-03-25 17:03:32 PDT

<rdar://problem/49236864>

Comment 2 Devin Rousso 2019-03-25 17:22:29 PDT

Created attachment 365924 [details]
Patch

Comment 3 Joseph Pecoraro 2019-04-15 11:35:44 PDT

Comment on attachment 365924 [details]
Patch

r=me, nice!

Comment 4 WebKit Commit Bot 2019-04-15 12:17:19 PDT

Comment on attachment 365924 [details]
Patch

Clearing flags on attachment: 365924

Committed r244279: <https://trac.webkit.org/changeset/244279>

Comment 5 WebKit Commit Bot 2019-04-15 12:17:20 PDT

All reviewed patches have been landed.  Closing bug.