| Summary: | [ews-build] Use PostgreSQL for ews-build database | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, dewei_zhu, jbedard, lforschler, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=220589 | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2019-03-25 16:51:26 PDT
Created attachment 365920 [details]
Patch
Comment on attachment 365920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365920&action=review > Tools/BuildSlaveSupport/ews-build/master.cfg:31 > + password = os.getenv('DB_PASSWORD', None) I'd stick with your convention above and call these db_username and db_password > Tools/BuildSlaveSupport/ews-build/master.cfg:32 > + if db_url is None or db_name is None or password is None or username is None: I find long comparisons like this clunky... how about something like: if None in [db_url, db_name, db_username, db_password]: Comment on attachment 365920 [details]
Patch
r+ with above changes.
Committed r243509: <https://trac.webkit.org/changeset/243509> |