Bug 196223

Summary: [WPE][GTK] Make building WebVR (w/OpenVR) not depend on ENABLE_EXPERIMENTAL_FEATURES
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, dbates, lforschler, mcatanzaro, pnormand, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 195889    
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2019-03-25 15:54:35 PDT
Features that depend on ENABLE_EXPERIMENTAL_FEATURES ideally should be buildable from release tarballs. If a feature is in development (or *very* experimental) and we do not want to include the sources needed to build it in release tarballs, then it should not depend on ENABLE_EXPERIMENTAL_FEATURES. (Note that this would just remove the dependency, the feature would still be buildable from a WebKit checkout by explicitly enabling it, of course.)
Attachments
Patch (2.71 KB, patch)
2019-03-25 17:27 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2019-03-25 17:27:42 PDT
Created attachment 365927 [details] Patch
WebKit Commit Bot
Comment 2 2019-03-25 19:18:19 PDT
Comment on attachment 365927 [details] Patch Clearing flags on attachment: 365927 Committed r243481: <https://trac.webkit.org/changeset/243481>
WebKit Commit Bot
Comment 3 2019-03-25 19:18:21 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-03-25 19:30:54 PDT
<rdar://problem/49241316>
Note You need to log in before you can comment on or make changes to this bug.