Bug 196223

Summary:

[WPE][GTK] Make building WebVR (w/OpenVR) not depend on ENABLE_EXPERIMENTAL_FEATURES

Product:

WebKit

Reporter:

Adrian Perez <aperez>

Component:

Tools / Tests

Assignee:

Adrian Perez <aperez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, commit-queue, dbates, lforschler, mcatanzaro, pnormand, svillar, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

195889

Attachments:

Description	Flags
Patch	none

Description Adrian Perez 2019-03-25 15:54:35 PDT

Features that depend on ENABLE_EXPERIMENTAL_FEATURES ideally should
be buildable from release tarballs. If a feature is in development
(or *very* experimental) and we do not want to include the sources
needed to build it in release tarballs, then it should not depend on
ENABLE_EXPERIMENTAL_FEATURES.

(Note that this would just remove the dependency, the feature would
still be buildable from a WebKit checkout by explicitly enabling it,
of course.)

Comment 1 Adrian Perez 2019-03-25 17:27:42 PDT

Created attachment 365927 [details]
Patch

Comment 2 WebKit Commit Bot 2019-03-25 19:18:19 PDT

Comment on attachment 365927 [details]
Patch

Clearing flags on attachment: 365927

Committed r243481: <https://trac.webkit.org/changeset/243481>

Comment 3 WebKit Commit Bot 2019-03-25 19:18:21 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2019-03-25 19:30:54 PDT

<rdar://problem/49241316>