Summary: | [WPE][GTK] Include the needed parts of ThidParty/libwebrtc in tarballs | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||
Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> | ||||
Status: | NEW --- | ||||||
Severity: | Normal | CC: | cgarcia, clopez, lforschler, mcatanzaro, mitz, thorton, ysuzuki | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 195889 | ||||||
Attachments: |
|
Description
Adrian Perez
2019-03-25 15:50:43 PDT
Created attachment 365925 [details]
WIP Patch
First pass at having the libwebrtc sources in the tarballs. With
this it is already possible to build the WPE and GTK ports from
their tarballs passing -DENABLE_WEB_RTC=ON to CMake. The tarballs
are still bloated (~50 MiB) and include many things which are not
strictly needed, so I will look into improving that.
I would like to test this but I'm unable to correctly execute the make-dist script. Do you have an example of how this script is executed to create release tarballs? make-dist -c -s <source-dir> path/to/manifest/file I usually run it from WebKitBuild/Release, so I do: $ make-dist -c -s../../ manifest.txt If you include this in tarballs before removing BoringSSL, people will build with it enabled, and GPL violations will result. (In reply to Carlos Garcia Campos from comment #3) > make-dist -c -s <source-dir> path/to/manifest/file > > I usually run it from WebKitBuild/Release, so I do: > > $ make-dist -c -s../../ manifest.txt Alternatively, pass “-DDEVELOPER_MODE=ON” to CMake, and then use “make dist” (or “ninja dist”). The patch is very WIP and doesn't work. When I stopped working on it it was at the point where a bit over a half of libwebrtc would build from a WebKitGTK tarball. It needs work. The BoringSSL issue mentioned by Michael is *very* real, so the idea here was to include the needed sources in the tarball, but leave the WebRTC support disabled by default, and making CMake spit out a big fat warning about the licensing when enabled. $0.02: nobody will read what CMake prints. Options we provide will be enabled somewhere. |