Bug 196187

Summary: [JSC] Move test into directory for WASM tests
Product: WebKit Reporter: Dominik Inführ <dominik.infuehr>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, guijemont, guijemont+jsc-armv7-ews, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews202 for win-future none

Dominik Inführ
Reported 2019-03-24 08:37:00 PDT
[JSC] Move test into directory for WASM tests
Attachments
Patch (1.58 KB, patch)
2019-03-24 08:38 PDT, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch (1.57 KB, patch)
2019-03-24 09:35 PDT, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews202 for win-future (12.92 MB, application/zip)
2019-03-24 15:04 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dominik Inführ
Comment 1 2019-03-24 08:38:28 PDT
Created attachment 365827 [details] Patch
Mark Lam
Comment 2 2019-03-24 09:15:41 PDT
Comment on attachment 365827 [details] Patch r=me but please move to JSTests/was/regress instead. Thanks.
Mark Lam
Comment 3 2019-03-24 09:15:58 PDT
(In reply to Mark Lam from comment #2) > Comment on attachment 365827 [details] > Patch > > r=me but please move to JSTests/was/regress instead. Thanks. I meant JSTests/wasm/regress.
Dominik Inführ
Comment 4 2019-03-24 09:35:34 PDT
Created attachment 365832 [details] Patch
EWS Watchlist
Comment 5 2019-03-24 15:04:25 PDT
Comment on attachment 365832 [details] Patch Attachment 365832 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11648844 New failing tests: animations/resume-after-page-cache.html js/dom/custom-constructors.html
EWS Watchlist
Comment 6 2019-03-24 15:04:37 PDT
Created attachment 365839 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
WebKit Commit Bot
Comment 7 2019-03-24 17:41:31 PDT
Comment on attachment 365832 [details] Patch Clearing flags on attachment: 365832 Committed r243428: <https://trac.webkit.org/changeset/243428>
WebKit Commit Bot
Comment 8 2019-03-24 17:41:32 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-03-24 17:45:16 PDT
<rdar://problem/49201878>
Dominik Inführ
Comment 10 2019-03-25 10:01:29 PDT
Unfortunately this wasn't enough, runDefault causes the test to run immediately. https://bugs.webkit.org/show_bug.cgi?id=196206 makes runDefault conditional.
Note You need to log in before you can comment on or make changes to this bug.