Summary: | [Apple Pay] Remove the AvailablePaymentNetworks synchronous message | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||||
Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, andersca, beidson, cdumez, commit-queue, thorton, timothy, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Andy Estes
2019-03-23 15:39:32 PDT
Created attachment 365819 [details]
Patch
Created attachment 365837 [details]
Patch
Comment on attachment 365837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365837&action=review > Source/WebKit/WebProcess/ApplePay/cocoa/WebPaymentCoordinatorCocoa.mm:46 > + result.uncheckedAppend(network); Can we add them to m_availablePaymentNetworks directly and return void? Or better, return a AvailablePaymentNetworksSet directly and make this a free function or a static WebPaymentCoordinator one. We could also change WebPaymentCoordinator::availablePaymentNetworks(): if (!m_availablePaymentNetworks) m_availablePaymentNetworks = platformAvailablePaymentNetworks(); return *m_availablePaymentNetworks; > Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:133 > + if (WebCore::AXObjectCache* cache = [self axObjectCache]) { auto? Created attachment 365874 [details]
Patch
(In reply to youenn fablet from comment #3) > Comment on attachment 365837 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=365837&action=review > > > Source/WebKit/WebProcess/ApplePay/cocoa/WebPaymentCoordinatorCocoa.mm:46 > > + result.uncheckedAppend(network); > > Can we add them to m_availablePaymentNetworks directly and return void? > Or better, return a AvailablePaymentNetworksSet directly and make this a > free function or a static WebPaymentCoordinator one. > We could also change WebPaymentCoordinator::availablePaymentNetworks(): > if (!m_availablePaymentNetworks) > m_availablePaymentNetworks = platformAvailablePaymentNetworks(); > return *m_availablePaymentNetworks; I got rid of availablePaymentNetworks entirely and moved its logic into validatedPaymentNetwork. I made platformAvailablePaymentNetworks return a AvailablePaymentNetworksSet as you suggested. > > > Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:133 > > + if (WebCore::AXObjectCache* cache = [self axObjectCache]) { > > auto? Yep. Thanks for reviewing! Comment on attachment 365874 [details] Patch Clearing flags on attachment: 365874 Committed r243443: <https://trac.webkit.org/changeset/243443> All reviewed patches have been landed. Closing bug. |