Bug 196164

Summary: Animated keyboard scrolling is extremely chaotic
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, dino, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2019-03-22 16:18:15 PDT
Animated keyboard scrolling is extremely chaotic
Attachments
Patch (5.41 KB, patch)
2019-03-22 16:18 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (5.18 KB, patch)
2019-03-25 13:09 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (5.30 KB, patch)
2019-03-25 13:20 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2019-03-22 16:18:28 PDT
Created attachment 365773 [details] Patch
Tim Horton
Comment 2 2019-03-22 16:18:30 PDT
<rdar://problem/48702444>
Tim Horton
Comment 3 2019-03-22 17:22:14 PDT
Comment on attachment 365773 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365773&action=review > Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm:360 > + WTFLogAlways("THORTON STOP"); Obviously without this 🙃
Simon Fraser (smfr)
Comment 4 2019-03-24 23:33:48 PDT
Comment on attachment 365773 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365773&action=review > Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.h:65 > +- (BOOL)hasScrollingKeyPressed; I don't like this term. It's no clear if it means "scrolling key is currently depressed", or "scrolling key was pressed sometime in the past".
Tim Horton
Comment 5 2019-03-24 23:48:07 PDT
(In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 365773 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=365773&action=review > > > Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.h:65 > > +- (BOOL)hasScrollingKeyPressed; > > I don't like this term. It's no clear if it means "scrolling key is > currently depressed", or "scrolling key was pressed sometime in the past". As you might be able to tell from the renaming in this patch, I'm having the same fight with myself :D I'll try a third name.
Tim Horton
Comment 6 2019-03-25 13:09:56 PDT
Created attachment 365889 [details] Patch
Simon Fraser (smfr)
Comment 7 2019-03-25 13:18:12 PDT
Comment on attachment 365889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365889&action=review > Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.h:65 > +- (BOOL)hasScrollingKeyDown; scrollTriggeringKeyIsPressed / scrollTriggeringKeyIsDown?
Tim Horton
Comment 8 2019-03-25 13:20:50 PDT
Created attachment 365890 [details] Patch
WebKit Commit Bot
Comment 9 2019-03-25 13:55:38 PDT
Comment on attachment 365890 [details] Patch Clearing flags on attachment: 365890 Committed r243454: <https://trac.webkit.org/changeset/243454>
WebKit Commit Bot
Comment 10 2019-03-25 13:55:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.