Bug 196161

Summary: Re-enable safe browsing in WKWebView
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, ggaren, krzysztof.modras, mcatanzaro, mjs, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212843
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews106 for mac-highsierra-wk2
none
Patch none

Alex Christensen
Reported 2019-03-22 15:11:43 PDT
Re-enable safe browsing in WKWebView
Attachments
Patch (11.76 KB, patch)
2019-03-22 15:14 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.97 MB, application/zip)
2019-03-22 16:36 PDT, EWS Watchlist 		no flags
Details
Patch (12.08 KB, patch)
2019-03-26 12:15 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-03-22 15:14:00 PDT
Created attachment 365765 [details] Patch
Alex Christensen
Comment 2 2019-03-22 15:14:03 PDT
<rdar://problem/49171413>
EWS Watchlist
Comment 3 2019-03-22 16:36:23 PDT
Comment on attachment 365765 [details] Patch Attachment 365765 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11617844 New failing tests: http/tests/navigation/keyboard-events-during-provisional-navigation.html imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html
EWS Watchlist
Comment 4 2019-03-22 16:36:25 PDT
Created attachment 365777 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Geoffrey Garen
Comment 5 2019-03-24 12:06:04 PDT
Comment on attachment 365765 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365765&action=review > LayoutTests/ChangeLog:9 > + * platform/mac-wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: Regressions: Unexpected text-only failures (1) http/tests/navigation/keyboard-events-during-provisional-navigation.html [ Failure ]
Alex Christensen
Comment 6 2019-03-26 12:15:21 PDT
Created attachment 365983 [details] Patch
WebKit Commit Bot
Comment 7 2019-06-05 14:24:51 PDT
Comment on attachment 365983 [details] Patch Clearing flags on attachment: 365983 Committed r246127: <https://trac.webkit.org/changeset/246127>
WebKit Commit Bot
Comment 8 2019-06-05 14:24:52 PDT
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 9 2019-06-06 10:26:37 PDT
Comment on attachment 365983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365983&action=review > Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h:59 > +/*! @abstract A Boolean value indicating whether warnings should be > + shown for suspected fraudulent content such as phishing or malware. > + @discussion The default value is YES. This feature is currently available > + in the following region: China. > + */ > +@property (nonatomic, getter=isFraudulentWebsiteWarningEnabled) BOOL fraudulentWebsiteWarningEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); It's only available in China?
Maciej Stachowiak
Comment 10 2020-02-19 01:38:50 PST
Unfortunately, we don't currently have the ability to offer this feature in other regions.
Note You need to log in before you can comment on or make changes to this bug.