| Summary: | Re-enable safe browsing in WKWebView | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, ggaren, krzysztof.modras, mcatanzaro, mjs, rniwa, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=212843 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alex Christensen
2019-03-22 15:11:43 PDT
Created attachment 365765 [details]
Patch
Comment on attachment 365765 [details] Patch Attachment 365765 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11617844 New failing tests: http/tests/navigation/keyboard-events-during-provisional-navigation.html imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html Created attachment 365777 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 365765 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365765&action=review > LayoutTests/ChangeLog:9 > + * platform/mac-wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: Regressions: Unexpected text-only failures (1) http/tests/navigation/keyboard-events-during-provisional-navigation.html [ Failure ] Created attachment 365983 [details]
Patch
Comment on attachment 365983 [details] Patch Clearing flags on attachment: 365983 Committed r246127: <https://trac.webkit.org/changeset/246127> All reviewed patches have been landed. Closing bug. Comment on attachment 365983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365983&action=review > Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h:59 > +/*! @abstract A Boolean value indicating whether warnings should be > + shown for suspected fraudulent content such as phishing or malware. > + @discussion The default value is YES. This feature is currently available > + in the following region: China. > + */ > +@property (nonatomic, getter=isFraudulentWebsiteWarningEnabled) BOOL fraudulentWebsiteWarningEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); It's only available in China? Unfortunately, we don't currently have the ability to offer this feature in other regions. |