Summary: | Include the CFNetworking task UUID to the NSError when a resource-load fails | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Rollin <krollin> | ||||||||
Component: | New Bugs | Assignee: | Keith Rollin <krollin> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, commit-queue, ews-watchlist, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Keith Rollin
2019-03-22 11:57:17 PDT
Created attachment 365753 [details]
Patch
Comment on attachment 365753 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365753&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:611 > + newUserInfo[@"networkTaskID"] = [task description]; Maybe we should have "Description" in the key instead of "ID" Comment on attachment 365753 [details] Patch Attachment 365753 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11616331 New failing tests: fast/visual-viewport/ios/min-scale-greater-than-one.html Created attachment 365758 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 366106 [details]
Patch
Changed ID to Description. Those test failures aren't mine. Comment on attachment 366106 [details] Patch Clearing flags on attachment: 366106 Committed r243565: <https://trac.webkit.org/changeset/243565> All reviewed patches have been landed. Closing bug. |