| Summary: | [css-grid] Fix grid container baseline alignment for orthogonal items | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||||||
| Component: | Layout and Rendering | Assignee: | Manuel Rego Casasnovas <rego> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, ews-watchlist, jfernandez, obrufau, rniwa, simon.fraser, svillar, webkit-bug-importer, zalan | ||||||||||
| Priority: | P2 | Keywords: | BlinkMergeCandidate, InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.chromium.org/p/chromium/issues/detail?id=943003 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Manuel Rego Casasnovas
2019-03-22 04:19:14 PDT
Created attachment 365708 [details]
Patch
Comment on attachment 365708 [details] Patch Attachment 365708 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11612508 New failing tests: imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html Created attachment 365718 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 365708 [details]
Patch
Looks good to me. The red bot seems unrelated, but please, check it out before landing.
(In reply to Javier Fernandez from comment #4) > Looks good to me. The red bot seems unrelated, but please, check it out > before landing. It seems totally unrelated to this patch, but I'll reupload the test to verify it in EWS again. Thanks for the review. Created attachment 365755 [details]
Patch
Comment on attachment 365755 [details] Patch Attachment 365755 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11617302 New failing tests: animations/resume-after-page-cache.html Created attachment 365766 [details]
Archive of layout-test-results from ews204 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment on attachment 365755 [details]
Patch
Again the failure seems totally unrelated, and win and wincairo EWS was green in the first patch (that is exactly the same than the second one).
So let's land this.
Comment on attachment 365755 [details] Patch Clearing flags on attachment: 365755 Committed r243432: <https://trac.webkit.org/changeset/243432> All reviewed patches have been landed. Closing bug. |