Bug 196141 - [css-grid] Fix grid container baseline alignment for orthogonal items
Summary: [css-grid] Fix grid container baseline alignment for orthogonal items
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords: BlinkMergeCandidate, InRadar
Depends on:
Blocks:
 
Reported: 2019-03-22 04:19 PDT by Manuel Rego Casasnovas
Modified: 2019-03-25 01:11 PDT (History)
10 users (show)

See Also:

Attachments
Patch (13.55 KB, patch)
2019-03-22 04:20 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.96 MB, application/zip)
2019-03-22 06:19 PDT, EWS Watchlist 		no flags Details
Patch (13.55 KB, patch)
2019-03-22 13:36 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews204 for win-future (12.86 MB, application/zip)
2019-03-22 15:38 PDT, EWS Watchlist 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2019-03-22 04:19:14 PDT 
[css-grid] Fix grid container baseline alignment for orthogonal items
Comment 1 Manuel Rego Casasnovas 2019-03-22 04:20:07 PDT 
Created attachment 365708 [details]
Patch
Comment 2 EWS Watchlist 2019-03-22 06:19:13 PDT 
Comment on attachment 365708 [details]
Patch

Attachment 365708 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11612508

New failing tests:
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html
Comment 3 EWS Watchlist 2019-03-22 06:19:15 PDT 
Created attachment 365718 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 4 Javier Fernandez 2019-03-22 06:21:37 PDT 
Comment on attachment 365708 [details]
Patch

Looks good to me. The red bot seems unrelated, but please, check it out before landing.
Comment 5 Manuel Rego Casasnovas 2019-03-22 13:34:35 PDT 
(In reply to Javier Fernandez from comment #4)
> Looks good to me. The red bot seems unrelated, but please, check it out
> before landing.

It seems totally unrelated to this patch, but I'll reupload the test to verify it in EWS again.

Thanks for the review.
Comment 6 Manuel Rego Casasnovas 2019-03-22 13:36:08 PDT 
Created attachment 365755 [details]
Patch
Comment 7 EWS Watchlist 2019-03-22 15:38:30 PDT 
Comment on attachment 365755 [details]
Patch

Attachment 365755 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11617302

New failing tests:
animations/resume-after-page-cache.html
Comment 8 EWS Watchlist 2019-03-22 15:38:41 PDT 
Created attachment 365766 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment 9 Manuel Rego Casasnovas 2019-03-25 00:21:00 PDT 
Comment on attachment 365755 [details]
Patch

Again the failure seems totally unrelated, and win and wincairo EWS was green in the first patch (that is exactly the same than the second one).
So let's land this.
Comment 10 WebKit Commit Bot 2019-03-25 00:47:00 PDT 
Comment on attachment 365755 [details]
Patch

Clearing flags on attachment: 365755

Committed r243432: <https://trac.webkit.org/changeset/243432>
Comment 11 WebKit Commit Bot 2019-03-25 00:47:02 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-03-25 00:47:26 PDT 
<rdar://problem/49207396>