| Summary: | REGRESSION (r242687): Flicker when pinch-zooming pages in macOS Safari | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cmarcelo, ews-watchlist, fred.wang, jamesr, koivisto, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2019-03-21 19:07:32 PDT
Created attachment 365665 [details]
Patch
Attachment 365665 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 365667 [details]
Patch
Comment on attachment 365667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365667&action=review > Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:91 > + enum class FlushingForTransientZoom { Yes, No }; Something like enum class FlushType { Normal, TransientZoom }; is another option here. Followup fix in https://trac.webkit.org/r243469 |