Bug 196126

Summary: REGRESSION (r242687): Flicker when pinch-zooming pages in macOS Safari
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ews-watchlist, fred.wang, jamesr, koivisto, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch koivisto: review+

Description Simon Fraser (smfr) 2019-03-21 19:07:32 PDT
REGRESSION (r242687): Flicker when pinch-zooming pages in macOS Safari
Comment 1 Simon Fraser (smfr) 2019-03-21 19:08:29 PDT Comment hidden (obsolete)
Comment 2 Simon Fraser (smfr) 2019-03-21 19:08:31 PDT
<rdar://problem/49095791>
Comment 3 EWS Watchlist 2019-03-21 19:10:25 PDT Comment hidden (obsolete)
Comment 4 Simon Fraser (smfr) 2019-03-21 19:12:46 PDT
Created attachment 365667 [details]
Patch
Comment 5 Antti Koivisto 2019-03-22 09:11:49 PDT
Comment on attachment 365667 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365667&action=review

> Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:91
> +    enum class FlushingForTransientZoom { Yes, No };

Something like

enum class FlushType { Normal, TransientZoom };

is another option here.
Comment 6 Simon Fraser (smfr) 2019-03-22 09:39:30 PDT
https://trac.webkit.org/changeset/243381/webkit
Comment 7 Simon Fraser (smfr) 2019-03-25 16:11:37 PDT
Followup fix in https://trac.webkit.org/r243469