Bug 196122

Summary:

[JSC] Shrink sizeof(FunctionExecutable) by 16bytes

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	saam: review+
Patch for landing	none

Description Yusuke Suzuki 2019-03-21 17:54:43 PDT

[JSC] Shrink sizeof(FunctionExecutable) by 16bytes

Comment 1 Yusuke Suzuki 2019-03-21 17:59:39 PDT

Created attachment 365659 [details]
Patch

Comment 2 Saam Barati 2019-03-21 19:03:21 PDT

Comment on attachment 365659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365659&action=review

> Source/JavaScriptCore/runtime/GlobalExecutable.h:34
> +    friend class LLIntOffsetsExtractor;

why?

Comment 3 Yusuke Suzuki 2019-03-21 19:26:36 PDT

Comment on attachment 365659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365659&action=review

>> Source/JavaScriptCore/runtime/GlobalExecutable.h:34
>> +    friend class LLIntOffsetsExtractor;
> 
> why?

It should be removed. Thanks

Comment 4 Yusuke Suzuki 2019-03-21 19:26:59 PDT

Created attachment 365670 [details]
Patch for landing

Comment 5 Yusuke Suzuki 2019-03-22 00:14:50 PDT

Committed r243365: <https://trac.webkit.org/changeset/243365>

Comment 6 Radar WebKit Bug Importer 2019-03-22 00:16:48 PDT

<rdar://problem/49143440>

Comment 7 Yusuke Suzuki 2019-03-22 00:39:50 PDT

Committed r243367: <https://trac.webkit.org/changeset/243367>