Bug 196122

Summary: [JSC] Shrink sizeof(FunctionExecutable) by 16bytes
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
saam: review+
Patch for landing none

Yusuke Suzuki
Reported 2019-03-21 17:54:43 PDT
[JSC] Shrink sizeof(FunctionExecutable) by 16bytes
Attachments
Patch (36.73 KB, patch)
2019-03-21 17:59 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Patch for landing (37.42 KB, patch)
2019-03-21 19:26 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-03-21 17:59:39 PDT
Created attachment 365659 [details] Patch
Saam Barati
Comment 2 2019-03-21 19:03:21 PDT
Comment on attachment 365659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365659&action=review > Source/JavaScriptCore/runtime/GlobalExecutable.h:34 > + friend class LLIntOffsetsExtractor; why?
Yusuke Suzuki
Comment 3 2019-03-21 19:26:36 PDT
Comment on attachment 365659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365659&action=review >> Source/JavaScriptCore/runtime/GlobalExecutable.h:34 >> + friend class LLIntOffsetsExtractor; > > why? It should be removed. Thanks
Yusuke Suzuki
Comment 4 2019-03-21 19:26:59 PDT
Created attachment 365670 [details] Patch for landing
Yusuke Suzuki
Comment 5 2019-03-22 00:14:50 PDT
Committed r243365: <https://trac.webkit.org/changeset/243365>
Radar WebKit Bug Importer
Comment 6 2019-03-22 00:16:48 PDT
<rdar://problem/49143440>
Yusuke Suzuki
Comment 7 2019-03-22 00:39:50 PDT
Committed r243367: <https://trac.webkit.org/changeset/243367>
Note You need to log in before you can comment on or make changes to this bug.