Bug 196111

Summary: AX: labels that only contains static text should not have children
Product: WebKit Reporter: Eric Liang <ericliang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ericliang, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch cfleizach: review-

Eric Liang
Reported 2019-03-21 14:22:48 PDT
Labels that only contains static text should not have children because the label is a static text.
Attachments
Patch (6.17 KB, patch)
2019-03-22 16:00 PDT, Eric Liang 		cfleizach: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-03-21 14:24:14 PDT
<rdar://problem/49124032>
Eric Liang
Comment 2 2019-03-22 16:00:03 PDT
Created attachment 365769 [details] Patch
chris fleizach
Comment 3 2019-03-24 10:04:04 PDT
Comment on attachment 365769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365769&action=review > Source/WebCore/accessibility/AccessibilityLabel.cpp:119 > + m_children.clear(); This seems like it should be covered by the dirty Boolean flag of the same name The way it’s coded now it will clear the children every time it’s asked (it appears)
chris fleizach
Comment 4 2019-04-08 10:32:54 PDT
Comment on attachment 365769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365769&action=review >> Source/WebCore/accessibility/AccessibilityLabel.cpp:119 >> + m_children.clear(); > > This seems like it should be covered by the dirty Boolean flag of the same name > > The way it’s coded now it will clear the children every time it’s asked (it appears) any comment on this?
Eric Liang
Comment 5 2019-04-08 10:38:59 PDT
Yes apparently I found issue on this patch. Somehow the children are still there. This needs rework apparently.
Note You need to log in before you can comment on or make changes to this bug.