Bug 196088

Summary:

Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Tools / Tests

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, bdakin, commit-queue, darin, ews-watchlist, fred.wang, glenn, lforschler, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Timothy Hatcher 2019-03-21 10:26:39 PDT

"WK_MAC_TBA is neither a version number nor WK_IOS_TBA"

That statement is true, it is not a number nor WK_IOS_TBA — nothing to see here. It sounds (at a glance) like it is expecting only a number — since macosx(WK_MAC_TBA) was also used on the same line. The missing part is this is about the WK_MAC_TBA being used in the ios() macro.

An error more like would help:

"ios(WK_MAC_TBA) is invalid; expected WK_IOS_TBA or a number"

Comment 1 Timothy Hatcher 2019-03-21 11:19:43 PDT

Created attachment 365575 [details]
Patch

Comment 2 BJ Burg 2019-03-21 11:26:20 PDT

Comment on attachment 365575 [details]
Patch

r=mews

Comment 3 Timothy Hatcher 2019-03-21 11:30:43 PDT

webkitpy failures are 3 other tests.

Comment 4 WebKit Commit Bot 2019-03-21 11:57:14 PDT

Comment on attachment 365575 [details]
Patch

Clearing flags on attachment: 365575

Committed r243308: <https://trac.webkit.org/changeset/243308>

Comment 5 WebKit Commit Bot 2019-03-21 11:57:16 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Radar WebKit Bug Importer 2019-03-21 11:59:11 PDT

<rdar://problem/49117433>