Bug 196088

Summary:

Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Tools / Tests

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, bdakin, commit-queue, darin, ews-watchlist, fred.wang, glenn, lforschler, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Timothy Hatcher

Reported 2019-03-21 10:26:39 PDT

"WK_MAC_TBA is neither a version number nor WK_IOS_TBA" That statement is true, it is not a number nor WK_IOS_TBA — nothing to see here. It sounds (at a glance) like it is expecting only a number — since macosx(WK_MAC_TBA) was also used on the same line. The missing part is this is about the WK_MAC_TBA being used in the ios() macro. An error more like would help: "ios(WK_MAC_TBA) is invalid; expected WK_IOS_TBA or a number"

Attachments
Patch (6.68 KB, patch) 2019-03-21 11:19 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.