Summary: | Remove the SVG tear off objects for SVGPathSeg, SVGPathSegList and SVGAnimatedPathSegList | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||||
Component: | SVG | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, jonlee, simon.fraser, webkit-bug-importer, zimmermann | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 191237 | ||||||||||
Attachments: |
|
Description
Said Abou-Hallawa
2019-03-21 10:17:26 PDT
Created attachment 365733 [details]
Patch
Comment on attachment 365733 [details] Patch Attachment 365733 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11614662 New failing tests: perf/svg-path-appenditem.html Created attachment 365751 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 365733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365733&action=review > Source/WebCore/svg/properties/SVGAnimatedPropertyAnimatorImpl.h:123 > + return std::unique_ptr<SVGAnimatedPathSegListAnimator>(new SVGAnimatedPathSegListAnimator(attributeName, animated, animationMode, calcMode, isAccumulated, isAdditive)); make_unique<> Created attachment 366080 [details]
Patch
Comment on attachment 366080 [details] Patch Clearing flags on attachment: 366080 Committed r243555: <https://trac.webkit.org/changeset/243555> All reviewed patches have been landed. Closing bug. |