Bug 196083

Summary: Remove the SVG tear off objects for SVGLength, SVGLengthList and SVGAnimatedLengthList
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: SVGAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jonlee, simon.fraser, sroberts, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 191237    
Attachments:
Description Flags
Patch
none
Patch none

Description Said Abou-Hallawa 2019-03-21 10:14:23 PDT 
This is part of removing the tear off objects of the SVG properties.
Comment 1 Radar WebKit Bug Importer 2019-03-21 13:42:18 PDT 
<rdar://problem/49121836>
Comment 2 Said Abou-Hallawa 2019-03-25 14:21:28 PDT 
Created attachment 365900 [details]
Patch
Comment 3 Said Abou-Hallawa 2019-03-26 11:57:46 PDT 
Created attachment 365981 [details]
Patch
Comment 4 WebKit Commit Bot 2019-03-26 13:14:40 PDT 
Comment on attachment 365981 [details]
Patch

Clearing flags on attachment: 365981

Committed r243515: <https://trac.webkit.org/changeset/243515>
Comment 5 WebKit Commit Bot 2019-03-26 13:14:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Shawn Roberts 2019-03-26 17:19:20 PDT 
It looks like https://trac.webkit.org/changeset/243515 is causing windows 10 build failures.

https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/3228

https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/3228/steps/compile-webkit/logs/stdio

Please let me know if it's a quick fix or we can roll out if you need more time?
Comment 7 Said Abou-Hallawa 2019-03-26 18:06:20 PDT 
Windows build fix: <https://trac.webkit.org/changeset/243532>