Bug 196083 - Remove the SVG tear off objects for SVGLength, SVGLengthList and SVGAnimatedLengthList
Summary: Remove the SVG tear off objects for SVGLength, SVGLengthList and SVGAnimatedL...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 191237
  Show dependency tree / graph
 
Reported: 2019-03-21 10:14 PDT by Said Abou-Hallawa
Modified: 2019-03-26 18:06 PDT (History)
6 users (show)

See Also:

Attachments
Patch (282.87 KB, patch)
2019-03-25 14:21 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (280.77 KB, patch)
2019-03-26 11:57 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-03-21 10:14:23 PDT 
This is part of removing the tear off objects of the SVG properties.
Comment 1 Radar WebKit Bug Importer 2019-03-21 13:42:18 PDT 
<rdar://problem/49121836>
Comment 2 Said Abou-Hallawa 2019-03-25 14:21:28 PDT 
Created attachment 365900 [details]
Patch
Comment 3 Said Abou-Hallawa 2019-03-26 11:57:46 PDT 
Created attachment 365981 [details]
Patch
Comment 4 WebKit Commit Bot 2019-03-26 13:14:40 PDT 
Comment on attachment 365981 [details]
Patch

Clearing flags on attachment: 365981

Committed r243515: <https://trac.webkit.org/changeset/243515>
Comment 5 WebKit Commit Bot 2019-03-26 13:14:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Shawn Roberts 2019-03-26 17:19:20 PDT 
It looks like https://trac.webkit.org/changeset/243515 is causing windows 10 build failures.

https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/3228

https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/3228/steps/compile-webkit/logs/stdio

Please let me know if it's a quick fix or we can roll out if you need more time?
Comment 7 Said Abou-Hallawa 2019-03-26 18:06:20 PDT 
Windows build fix: <https://trac.webkit.org/changeset/243532>