Bug 196078

Summary:

JSObject::putDirectIndexSlowOrBeyondVectorLength should check if indexIsSufficientlyBeyondLengthForSparseMap

Product:

WebKit

Reporter:

Tadeu Zagallo <tzagallo>

Component:

JavaScriptCore

Assignee:

Tadeu Zagallo <tzagallo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, rmorisset, saam, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Tadeu Zagallo 2019-03-21 08:39:55 PDT

...

Comment 1 Tadeu Zagallo 2019-03-21 08:42:14 PDT

Created attachment 365548 [details]
Patch

Comment 2 Tadeu Zagallo 2019-03-21 08:47:26 PDT

<rdar://problem/35925380>

Comment 3 Mark Lam 2019-03-21 09:18:59 PDT

Comment on attachment 365548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365548&action=review

r=me

> JSTests/ChangeLog:9
> +        * microbenchmarks/put-by-val-direct-large-index.js: Added.

Please record here what gains the microbenchmark shows.

Comment 4 Tadeu Zagallo 2019-03-21 09:52:14 PDT

Created attachment 365561 [details]
Patch for landing

Comment 5 WebKit Commit Bot 2019-03-21 10:42:46 PDT

Comment on attachment 365561 [details]
Patch for landing

Clearing flags on attachment: 365561

Committed r243299: <https://trac.webkit.org/changeset/243299>

Comment 6 WebKit Commit Bot 2019-03-21 10:42:48 PDT

All reviewed patches have been landed.  Closing bug.