Bug 196078

Summary: JSObject::putDirectIndexSlowOrBeyondVectorLength should check if indexIsSufficientlyBeyondLengthForSparseMap
Product: WebKit Reporter: Tadeu Zagallo <tzagallo>
Component: JavaScriptCoreAssignee: Tadeu Zagallo <tzagallo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, rmorisset, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Tadeu Zagallo
Reported 2019-03-21 08:39:55 PDT
...
Attachments
Patch (3.04 KB, patch)
2019-03-21 08:42 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.20 KB, patch)
2019-03-21 09:52 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2019-03-21 08:42:14 PDT
Created attachment 365548 [details] Patch
Tadeu Zagallo
Comment 2 2019-03-21 08:47:26 PDT
<rdar://problem/35925380>
Mark Lam
Comment 3 2019-03-21 09:18:59 PDT
Comment on attachment 365548 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365548&action=review r=me > JSTests/ChangeLog:9 > + * microbenchmarks/put-by-val-direct-large-index.js: Added. Please record here what gains the microbenchmark shows.
Tadeu Zagallo
Comment 4 2019-03-21 09:52:14 PDT
Created attachment 365561 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-03-21 10:42:46 PDT
Comment on attachment 365561 [details] Patch for landing Clearing flags on attachment: 365561 Committed r243299: <https://trac.webkit.org/changeset/243299>
WebKit Commit Bot
Comment 6 2019-03-21 10:42:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.