Bug 196075

Summary: All PointerEvent.isTrusted is always false.
Product: WebKit Reporter: misinoe.t
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates, esprehn+autocc, ews-watchlist, graouts, jiewen_tan, kangil.han, tem.eknis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Mac   
OS: macOS 10.14   
Attachments:
Description Flags
please ⌥⌘C、The value of PointerEent.isTrusted is displayed
none
Patch cdumez: review+, cdumez: commit-queue-

misinoe.t
Reported 2019-03-21 07:17:53 PDT
Created attachment 365543 [details] please ⌥⌘C、The value of PointerEent.isTrusted is displayed environment: * macOS Mojave 10.14.3 * Safari Technology Preview: Release 78 (Safari 12.2, WebKit 14608.1.9.1) * menu -> Develop -> Experimental Features -> ☑Pointer Events All PointerEvent.isTrusted values ​​are always false. This can not really determine if the user has 'pointerdown'. Can Trusted PointerEvent.isTrusted tobe true?
Attachments
please ⌥⌘C、The value of PointerEent.isTrusted is displayed (945 bytes, text/html)
2019-03-21 07:17 PDT, misinoe.t 		no flags
Details
Patch (12.68 KB, patch)
2019-03-28 03:13 PDT, Antoine Quint 		cdumez: review+
cdumez: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-03-22 10:31:12 PDT
<rdar://problem/49158778>
Antoine Quint
Comment 2 2019-03-27 06:40:49 PDT
Alas, the MouseEvent constructor we're using does not take in IsTrusted, so we'll need to move to a constructor that does, and the one available does not accepted an initializer.
Antoine Quint
Comment 3 2019-03-27 07:06:30 PDT
This only affects macOS, on iOS we're overriding MouseEvent constructors that already allow for IsTrusted to be passed in and where we always pass IsTrusted::Yes.
Antoine Quint
Comment 4 2019-03-28 03:13:21 PDT
Created attachment 366161 [details] Patch
Chris Dumez
Comment 5 2019-03-28 08:40:41 PDT
Comment on attachment 366161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366161&action=review r=me with comments. > Source/WebCore/dom/PointerEvent.cpp:87 > +Ref<PointerEvent> PointerEvent::createPointerCancelEvent(PointerID pointerId, String pointerType) const String& or maybe const AtomicString&. > Source/WebCore/dom/PointerEvent.cpp:115 > +PointerEvent::PointerEvent(const AtomicString& type, CanBubble canBubble, IsCancelable isCancelable, IsComposed isComposed, PointerID pointerId, String pointerType) const String& or const AtomicString&, not String. > Source/WebCore/dom/PointerEvent.h:76 > + static Ref<PointerEvent> createPointerCancelEvent(PointerID, String pointerType); const String& or const AtomicString&.
Antoine Quint
Comment 6 2019-03-29 08:54:11 PDT
Committed r243645: <https://trac.webkit.org/changeset/243645>
Note You need to log in before you can comment on or make changes to this bug.