Bug 196070

Summary:

Remove NavigatorContentUtils in WebCore/Modules

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

WebCore Misc.

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none
Patch	none
Patch for landing	none

Gyuyoung Kim

Reported 2019-03-21 02:05:18 PDT

NavigatorContentUtils was to support the custom scheme spec - https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers. However, in WebKit side, no port has supported the feature in the WebKit layer after EFL port was removed. So there has been the only IDL implementation of the NavigatorContentUtils in WebCore. So let's remove the partial implementation in WebCore.

Attachments
Patch (98.24 KB, patch) 2019-03-21 02:29 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (98.84 KB, patch) 2019-03-21 02:46 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch for landing (97.85 KB, patch) 2019-03-24 20:42 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (97.85 KB, patch) 2019-03-24 21:54 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch for landing (97.83 KB, patch) 2019-03-24 23:36 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2019-03-21 02:29:23 PDT

Created attachment 365523 [details] Patch

Gyuyoung Kim

Comment 2 2019-03-21 02:46:03 PDT

Created attachment 365525 [details] Patch

Gyuyoung Kim

Comment 3 2019-03-21 18:04:35 PDT

Comment on attachment 365525 [details] Patch If there is any port which has been using this feature or will use it in the future, please let me know.

Alex Christensen

Comment 4 2019-03-22 10:09:36 PDT

Comment on attachment 365525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365525&action=review If we decide to implement or ship this, we can refer to the svn history. If it's just dead code, let's remove it. > Source/JavaScriptCore/ChangeLog:-138 > - * Configurations/FeatureDefines.xcconfig: > - This should be left as it was.

Gyuyoung Kim

Comment 5 2019-03-24 20:04:49 PDT

Comment on attachment 365525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365525&action=review >> Source/JavaScriptCore/ChangeLog:-138 >> - > > This should be left as it was. Right. I did a mistake when I rebase this patch.

Gyuyoung Kim

Comment 6 2019-03-24 20:08:23 PDT

> If we decide to implement or ship this, we can refer to the svn history. If it's just dead code, let's remove it. If someone wants to implement or ship this feature in the future, we can start to work after reverting this patch. But, as far as I know, nobody supports this feature in WebKit upstream ports now.

Gyuyoung Kim

Comment 7 2019-03-24 20:42:39 PDT

Created attachment 365845 [details] Patch for landing

Gyuyoung Kim

Comment 8 2019-03-24 21:54:18 PDT

Created attachment 365847 [details] Patch

Gyuyoung Kim

Comment 9 2019-03-24 23:36:02 PDT

Created attachment 365852 [details] Patch for landing

WebKit Commit Bot

Comment 10 2019-03-25 01:07:20 PDT

Comment on attachment 365852 [details] Patch for landing Clearing flags on attachment: 365852 Committed r243433: <https://trac.webkit.org/changeset/243433>

WebKit Commit Bot

Comment 11 2019-03-25 01:07:22 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 12 2019-03-25 01:08:23 PDT

<rdar://problem/49207736>

Note You need to log in before you can comment on or make changes to this bug.