Bug 196070

Summary: Remove NavigatorContentUtils in WebCore/Modules
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebCore Misc.Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch
none
Patch for landing none

Description Gyuyoung Kim 2019-03-21 02:05:18 PDT
NavigatorContentUtils was to support the custom scheme spec - https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers. However, in WebKit side, no port has supported the feature in the WebKit layer after EFL port was removed. So there has been the only IDL implementation of the NavigatorContentUtils in WebCore. So let's remove the partial implementation in WebCore.
Comment 1 Gyuyoung Kim 2019-03-21 02:29:23 PDT
Created attachment 365523 [details]
Patch
Comment 2 Gyuyoung Kim 2019-03-21 02:46:03 PDT
Created attachment 365525 [details]
Patch
Comment 3 Gyuyoung Kim 2019-03-21 18:04:35 PDT
Comment on attachment 365525 [details]
Patch

If there is any port which has been using this feature or will use it in the future, please let me know.
Comment 4 Alex Christensen 2019-03-22 10:09:36 PDT
Comment on attachment 365525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365525&action=review

If we decide to implement or ship this, we can refer to the svn history.  If it's just dead code, let's remove it.

> Source/JavaScriptCore/ChangeLog:-138
> -        * Configurations/FeatureDefines.xcconfig:
> -

This should be left as it was.
Comment 5 Gyuyoung Kim 2019-03-24 20:04:49 PDT
Comment on attachment 365525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365525&action=review

>> Source/JavaScriptCore/ChangeLog:-138
>> -
> 
> This should be left as it was.

Right. I did a mistake when I rebase this patch.
Comment 6 Gyuyoung Kim 2019-03-24 20:08:23 PDT
> If we decide to implement or ship this, we can refer to the svn history.  If it's just dead code, let's remove it.

If someone wants to implement or ship this feature in the future, we can start to work after reverting this patch. But, as far as I know, nobody supports this feature in WebKit upstream ports now.
Comment 7 Gyuyoung Kim 2019-03-24 20:42:39 PDT
Created attachment 365845 [details]
Patch for landing
Comment 8 Gyuyoung Kim 2019-03-24 21:54:18 PDT
Created attachment 365847 [details]
Patch
Comment 9 Gyuyoung Kim 2019-03-24 23:36:02 PDT
Created attachment 365852 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2019-03-25 01:07:20 PDT
Comment on attachment 365852 [details]
Patch for landing

Clearing flags on attachment: 365852

Committed r243433: <https://trac.webkit.org/changeset/243433>
Comment 11 WebKit Commit Bot 2019-03-25 01:07:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-03-25 01:08:23 PDT
<rdar://problem/49207736>