Bug 196047

Summary:

Web Inspector: create CommandLineAPIHost lazily like the other agents

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, rniwa, saam, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Archive of layout-test-results from ews215 for win-future	none
Archive of layout-test-results from ews112 for mac-highsierra	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews102 for mac-highsierra	none
Archive of layout-test-results from ews104 for mac-highsierra-wk2	none
Patch	none
Patch	none
Archive of layout-test-results from ews103 for mac-highsierra	none
Archive of layout-test-results from ews104 for mac-highsierra-wk2	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Archive of layout-test-results from ews116 for mac-highsierra	none
Archive of layout-test-results from ews212 for win-future	none
Patch	none
Patch	none

Devin Rousso

Reported 2019-03-20 17:50:19 PDT

We don't need the command line API to be available until we connect a frontend.

Attachments
Patch (9.36 KB, patch) 2019-05-05 23:06 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (922.00 KB, application/zip) 2019-05-05 23:56 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (1001.17 KB, application/zip) 2019-05-06 00:04 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews215 for win-future (8.78 MB, application/zip) 2019-05-06 00:11 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-highsierra (955.91 KB, application/zip) 2019-05-06 00:17 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (681.21 KB, application/zip) 2019-05-06 00:31 PDT, EWS Watchlist	no flags	Details
Patch (9.37 KB, patch) 2019-05-13 12:06 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-highsierra (900.50 KB, application/zip) 2019-05-13 12:59 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (942.63 KB, application/zip) 2019-05-13 13:06 PDT, EWS Watchlist	no flags	Details
Patch (8.09 KB, patch) 2019-05-13 13:20 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (8.08 KB, patch) 2019-05-13 17:53 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-highsierra (931.50 KB, application/zip) 2019-05-13 18:45 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (959.78 KB, application/zip) 2019-05-13 18:51 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (1.12 MB, application/zip) 2019-05-13 18:54 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews116 for mac-highsierra (945.90 KB, application/zip) 2019-05-13 19:05 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews212 for win-future (7.94 MB, application/zip) 2019-05-13 21:17 PDT, EWS Watchlist	no flags	Details
Patch (9.57 KB, patch) 2019-05-15 01:07 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (9.57 KB, patch) 2019-05-15 04:04 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (17) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-03-20 17:50:36 PDT

<rdar://problem/49087835>

Devin Rousso

Comment 2 2019-05-05 23:06:39 PDT

Created attachment 369100 [details] Patch

EWS Watchlist

Comment 3 2019-05-05 23:56:50 PDT Comment hidden (obsolete)

Comment on attachment 369100 [details] Patch Attachment 369100 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12109144 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 4 2019-05-05 23:56:52 PDT Comment hidden (obsolete)

Created attachment 369102 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 5 2019-05-06 00:04:51 PDT Comment hidden (obsolete)

Comment on attachment 369100 [details] Patch Attachment 369100 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12109149 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 6 2019-05-06 00:04:53 PDT Comment hidden (obsolete)

Created attachment 369104 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 7 2019-05-06 00:11:00 PDT Comment hidden (obsolete)

Comment on attachment 369100 [details] Patch Attachment 369100 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12109225 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 8 2019-05-06 00:11:02 PDT Comment hidden (obsolete)

Created attachment 369105 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

EWS Watchlist

Comment 9 2019-05-06 00:17:03 PDT Comment hidden (obsolete)

Comment on attachment 369100 [details] Patch Attachment 369100 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12109142 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 10 2019-05-06 00:17:05 PDT Comment hidden (obsolete)

Created attachment 369107 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 11 2019-05-06 00:31:04 PDT Comment hidden (obsolete)

Comment on attachment 369100 [details] Patch Attachment 369100 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12109223 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 12 2019-05-06 00:31:05 PDT Comment hidden (obsolete)

Created attachment 369109 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4

Devin Rousso

Comment 13 2019-05-13 12:06:25 PDT

Created attachment 369759 [details] Patch Rebase, to see if the test failures are actually caused by this change.

EWS Watchlist

Comment 14 2019-05-13 12:59:00 PDT Comment hidden (obsolete)

Comment on attachment 369759 [details] Patch Attachment 369759 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12179789 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 15 2019-05-13 12:59:02 PDT Comment hidden (obsolete)

Created attachment 369767 [details] Archive of layout-test-results from ews102 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 16 2019-05-13 13:05:58 PDT Comment hidden (obsolete)

Comment on attachment 369759 [details] Patch Attachment 369759 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12179818 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 17 2019-05-13 13:06:00 PDT Comment hidden (obsolete)

Created attachment 369768 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Devin Rousso

Comment 18 2019-05-13 13:20:16 PDT

Created attachment 369771 [details] Patch

Devin Rousso

Comment 19 2019-05-13 17:53:27 PDT

Created attachment 369805 [details] Patch

EWS Watchlist

Comment 20 2019-05-13 18:45:44 PDT Comment hidden (obsolete)

Comment on attachment 369805 [details] Patch Attachment 369805 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12183265 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 21 2019-05-13 18:45:46 PDT Comment hidden (obsolete)

Created attachment 369806 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 22 2019-05-13 18:51:43 PDT Comment hidden (obsolete)

Comment on attachment 369805 [details] Patch Attachment 369805 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12183266 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 23 2019-05-13 18:51:45 PDT Comment hidden (obsolete)

Created attachment 369807 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 24 2019-05-13 18:54:15 PDT Comment hidden (obsolete)

Comment on attachment 369805 [details] Patch Attachment 369805 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12183156 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 25 2019-05-13 18:54:17 PDT Comment hidden (obsolete)

Created attachment 369808 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4

EWS Watchlist

Comment 26 2019-05-13 19:05:09 PDT Comment hidden (obsolete)

Comment on attachment 369805 [details] Patch Attachment 369805 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12183257 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 27 2019-05-13 19:05:11 PDT Comment hidden (obsolete)

Created attachment 369809 [details] Archive of layout-test-results from ews116 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 28 2019-05-13 21:17:06 PDT Comment hidden (obsolete)

Comment on attachment 369805 [details] Patch Attachment 369805 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12184291 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 29 2019-05-13 21:17:09 PDT Comment hidden (obsolete)

Created attachment 369818 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Devin Rousso

Comment 30 2019-05-15 01:07:44 PDT

Created attachment 369937 [details] Patch

Devin Rousso

Comment 31 2019-05-15 04:04:01 PDT

Created attachment 369945 [details] Patch

WebKit Commit Bot

Comment 32 2019-06-06 16:31:46 PDT

Comment on attachment 369945 [details] Patch Clearing flags on attachment: 369945 Committed r246177: <https://trac.webkit.org/changeset/246177>

WebKit Commit Bot

Comment 33 2019-06-06 16:31:48 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.