Bug 196023

Summary: [iOS] Enable fast clicking everywhere
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: ryanhaddad, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch wenson_hsieh: review+

Description Dean Jackson 2019-03-20 12:34:25 PDT
[iOS] Enable fast clicking everywhere
Comment 1 Radar WebKit Bug Importer 2019-03-20 12:34:51 PDT
<rdar://problem/49073589>
Comment 2 Dean Jackson 2019-03-20 12:38:43 PDT
Created attachment 365384 [details]
Patch
Comment 3 Wenson Hsieh 2019-03-20 14:07:22 PDT
Comment on attachment 365384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365384&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1506
> +  defaultValue: true

I think we should still always be able to double tap to zoom on watchOS.

(Let's also confirm that this is what we want on iPhone, not just iPad).
Comment 4 Dean Jackson 2019-03-20 14:10:52 PDT
Comment on attachment 365384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365384&action=review

>> Source/WebKit/Shared/WebPreferences.yaml:1506
>> +  defaultValue: true
> 
> I think we should still always be able to double tap to zoom on watchOS.
> 
> (Let's also confirm that this is what we want on iPhone, not just iPad).

We've decided to put it on for now with iPhone. After living on, we might restrict to to just iPad, and then just iPad with sites that haven't set a viewport.
Comment 5 Dean Jackson 2019-03-20 14:28:18 PDT
Committed r243241: <https://trac.webkit.org/changeset/243241>
Comment 6 Ryan Haddad 2019-03-20 17:10:38 PDT
This caused http/tests/adClickAttribution/anchor-tag-attributes-validation.html and http/tests/security/anchor-download-block-crossorigin.html to start failing again due to changing console log line numbers. 

Rebaselined in https://trac.webkit.org/changeset/243262/webkit