Bug 196019

Summary: DFGNodeAllocator.h is dead code
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: JavaScriptCoreAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Robin Morisset
Reported 2019-03-20 11:41:01 PDT
As explained by Yusuke on IRC, the comment on DFG::Node saying that it cannot have a destructor is obsolete since https://trac.webkit.org/changeset/216815/webkit. This patch removes both the comment and DFGNodeAllocator.h that that patch forgot to remove.
Attachments
Patch (3.41 KB, patch)
2019-03-20 11:43 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2019-03-20 11:43:11 PDT
Created attachment 365370 [details] Patch
Yusuke Suzuki
Comment 2 2019-03-20 11:51:17 PDT
Comment on attachment 365370 [details] Patch r=me
WebKit Commit Bot
Comment 3 2019-03-20 13:37:07 PDT
Comment on attachment 365370 [details] Patch Clearing flags on attachment: 365370 Committed r243236: <https://trac.webkit.org/changeset/243236>
WebKit Commit Bot
Comment 4 2019-03-20 13:37:08 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-03-20 13:38:22 PDT
<rdar://problem/49076340>
Note You need to log in before you can comment on or make changes to this bug.