Bug 196012

Summary: Open source arm64e code.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, fpizlo, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
proposed patch. keith_miller: review+

Mark Lam
Reported 2019-03-20 10:15:40 PDT
Patch coming.
Attachments
proposed patch. (86.42 KB, patch)
2019-03-20 11:33 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (86.29 KB, patch)
2019-03-20 11:58 PDT, Mark Lam 		keith_miller: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-03-20 10:16:03 PDT
<rdar://problem/49066237>
Mark Lam
Comment 2 2019-03-20 11:33:14 PDT
Created attachment 365365 [details] proposed patch.
EWS Watchlist
Comment 3 2019-03-20 11:37:33 PDT
Attachment 365365 [details] did not pass style-queue: ERROR: Source/WTF/wtf/PlatformRegisters.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/PtrTag.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 2 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 4 2019-03-20 11:58:35 PDT
Created attachment 365378 [details] proposed patch.
EWS Watchlist
Comment 5 2019-03-20 12:03:25 PDT
Attachment 365378 [details] did not pass style-queue: ERROR: Source/WTF/wtf/PlatformRegisters.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/PtrTag.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 2 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 6 2019-03-20 12:03:26 PDT
Comment on attachment 365378 [details] proposed patch. r=me.
Mark Lam
Comment 7 2019-03-20 16:33:39 PDT
Thanks for the review. Landed in r243254: <http://trac.webkit.org/r243254>.
Note You need to log in before you can comment on or make changes to this bug.