Summary: | Open source arm64e code. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, dbates, ews-watchlist, fpizlo, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Mark Lam
2019-03-20 10:15:40 PDT
Created attachment 365365 [details]
proposed patch.
Attachment 365365 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/PlatformRegisters.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WTF/wtf/PtrTag.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 2 in 30 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 365378 [details]
proposed patch.
Attachment 365378 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/PlatformRegisters.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WTF/wtf/PtrTag.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 2 in 30 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 365378 [details]
proposed patch.
r=me.
Thanks for the review. Landed in r243254: <http://trac.webkit.org/r243254>. |