Bug 196009

Summary: "Reveal in Layers Tab" context menu option should not be available if the Layers Tab has not been enabled
Product: WebKit Reporter: Sam Weinig <sam>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sam Weinig
Reported 2019-03-20 09:39:53 PDT
If you right-click on an element in the Elements tab of the Web Inspector, there is an option to "Reveal in Layers Tab" even if the Layers Tab has not been enabled via the experimental settings. It seems like it should probably be hidden until the Layers Tab is no longer considered experimental.
Attachments
Patch (1.54 KB, patch)
2019-03-20 10:11 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-03-20 10:11:27 PDT
Created attachment 365352 [details] Patch
Sam Weinig
Comment 2 2019-03-20 11:05:00 PDT
Comment on attachment 365352 [details] Patch Do have tests for this type of thing?
Joseph Pecoraro
Comment 3 2019-03-20 11:46:46 PDT
Comment on attachment 365352 [details] Patch r=me
WebKit Commit Bot
Comment 4 2019-03-20 12:11:06 PDT
Comment on attachment 365352 [details] Patch Clearing flags on attachment: 365352 Committed r243224: <https://trac.webkit.org/changeset/243224>
WebKit Commit Bot
Comment 5 2019-03-20 12:11:08 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-03-20 12:22:33 PDT
<rdar://problem/49073152>
Note You need to log in before you can comment on or make changes to this bug.