Bug 196009 - "Reveal in Layers Tab" context menu option should not be available if the Layers Tab has not been enabled
Summary: "Reveal in Layers Tab" context menu option should not be available if the Lay...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-20 09:39 PDT by Sam Weinig
Modified: 2019-03-20 12:22 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2019-03-20 10:11 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2019-03-20 09:39:53 PDT 
If you right-click on an element in the Elements tab of the Web Inspector, there is an option to "Reveal in Layers Tab" even if the Layers Tab has not been enabled via the experimental settings. It seems like it should probably be hidden until the Layers Tab is no longer considered experimental.
Comment 1 Devin Rousso 2019-03-20 10:11:27 PDT 
Created attachment 365352 [details]
Patch
Comment 2 Sam Weinig 2019-03-20 11:05:00 PDT 
Comment on attachment 365352 [details]
Patch

Do have tests for this type of thing?
Comment 3 Joseph Pecoraro 2019-03-20 11:46:46 PDT 
Comment on attachment 365352 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-03-20 12:11:06 PDT 
Comment on attachment 365352 [details]
Patch

Clearing flags on attachment: 365352

Committed r243224: <https://trac.webkit.org/changeset/243224>
Comment 5 WebKit Commit Bot 2019-03-20 12:11:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-03-20 12:22:33 PDT 
<rdar://problem/49073152>