Bug 195993

Summary: ContentChangeObserver build error for not include Element.h
Product: WebKit Reporter: cathiechen <cathiechen>
Component: WebCore Misc.Assignee: cathiechen <cathiechen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rbuis, rwlbuis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description cathiechen 2019-03-20 01:57:47 PDT 
ContentChangeObserver should include Element.h
Comment 1 cathiechen 2019-03-20 02:03:50 PDT 
Created attachment 365327 [details]
Patch
Comment 2 cathiechen 2019-03-20 02:06:10 PDT 
Created attachment 365328 [details]
Patch
Comment 3 Rob Buis 2019-03-20 02:27:02 PDT 
Comment on attachment 365328 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365328&action=review

ContentChangeObserver.h may need more fixes, I see Frame is used as well. Change does not hurt though so let's go for it, with ChangeLog improvement please.

> Source/WebCore/ChangeLog:8
> +        ContentChangeObserver should include Element.h.

Please add some more context, i.e. how you found out there is a build error.
Comment 4 cathiechen 2019-03-20 02:34:40 PDT 
Comment on attachment 365328 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365328&action=review

Hi Rob,

Thanks for the review! :)

>> Source/WebCore/ChangeLog:8
>> +        ContentChangeObserver should include Element.h.
> 
> Please add some more context, i.e. how you found out there is a build error.

Done.
Comment 5 cathiechen 2019-03-20 02:36:05 PDT 
Created attachment 365330 [details]
Patch
Comment 6 Rob Buis 2019-03-20 02:39:38 PDT 
Comment on attachment 365330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365330&action=review

> Source/WebCore/page/ios/ContentChangeObserver.cpp:33
> +#include "Element.h"

I forgot, this include should not be needed since we include HTMLImageElement.h.
Comment 7 cathiechen 2019-03-20 02:52:36 PDT 
Created attachment 365331 [details]
Patch
Comment 8 Rob Buis 2019-03-21 08:28:45 PDT 
Comment on attachment 365331 [details]
Patch

Retry.
Comment 9 WebKit Commit Bot 2019-03-21 08:43:41 PDT 
Comment on attachment 365331 [details]
Patch

Clearing flags on attachment: 365331

Committed r243290: <https://trac.webkit.org/changeset/243290>
Comment 10 WebKit Commit Bot 2019-03-21 08:43:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2019-03-21 08:44:19 PDT 
<rdar://problem/49108425>