Bug 195971

Summary:

Web Inspector: Inspector: lazily create the agent

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

195587, 196725

Bug Blocks:

196925

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-highsierra	none
Archive of layout-test-results from ews107 for mac-highsierra-wk2	none
Archive of layout-test-results from ews114 for mac-highsierra	none
Patch	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews107 for mac-highsierra-wk2	none
Patch	none

Devin Rousso

Reported 2019-03-19 15:56:04 PDT

Attachments
Patch (7.38 KB, patch) 2019-03-19 17:39 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-highsierra (2.56 MB, application/zip) 2019-03-19 18:27 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (2.66 MB, application/zip) 2019-03-19 19:54 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-highsierra (2.57 MB, application/zip) 2019-03-19 20:43 PDT, EWS Watchlist	no flags	Details
Patch (7.51 KB, patch) 2019-03-20 12:02 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (7.10 KB, patch) 2019-03-20 16:44 PDT, Devin Rousso	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (2.62 MB, application/zip) 2019-03-20 20:36 PDT, EWS Watchlist	no flags	Details
Patch (8.22 KB, patch) 2019-04-09 13:24 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-03-19 15:56:37 PDT

<rdar://problem/49039645>

Devin Rousso

Comment 2 2019-03-19 17:39:52 PDT

Created attachment 365271 [details] Patch

EWS Watchlist

Comment 3 2019-03-19 18:27:21 PDT Comment hidden (obsolete)

Comment on attachment 365271 [details] Patch Attachment 365271 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11573230 New failing tests: inspector/runtime/CommandLineAPI-inspect.html

EWS Watchlist

Comment 4 2019-03-19 18:27:23 PDT Comment hidden (obsolete)

Created attachment 365281 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

Joseph Pecoraro

Comment 5 2019-03-19 18:48:34 PDT

Comment on attachment 365271 [details] Patch r=me

EWS Watchlist

Comment 6 2019-03-19 19:54:11 PDT Comment hidden (obsolete)

Comment on attachment 365271 [details] Patch Attachment 365271 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11574232 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 7 2019-03-19 19:54:12 PDT Comment hidden (obsolete)

Created attachment 365296 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 8 2019-03-19 20:43:10 PDT Comment hidden (obsolete)

Comment on attachment 365271 [details] Patch Attachment 365271 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11574554 New failing tests: inspector/runtime/CommandLineAPI-inspect.html

EWS Watchlist

Comment 9 2019-03-19 20:43:11 PDT Comment hidden (obsolete)

Created attachment 365300 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6

Devin Rousso

Comment 10 2019-03-20 12:02:21 PDT

Created attachment 365379 [details] Patch

Devin Rousso

Comment 11 2019-03-20 16:44:28 PDT

Created attachment 365435 [details] Patch

EWS Watchlist

Comment 12 2019-03-20 20:36:16 PDT Comment hidden (obsolete)

Comment on attachment 365435 [details] Patch Attachment 365435 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11590552 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 13 2019-03-20 20:36:18 PDT Comment hidden (obsolete)

Created attachment 365475 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Devin Rousso

Comment 14 2019-04-09 13:24:55 PDT

Created attachment 367067 [details] Patch Waiting for dependency.

WebKit Commit Bot

Comment 15 2019-04-10 17:33:34 PDT

Comment on attachment 367067 [details] Patch Clearing flags on attachment: 367067 Committed r244172: <https://trac.webkit.org/changeset/244172>

WebKit Commit Bot

Comment 16 2019-04-10 17:33:36 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.