Remove the SVG property tear off objects of SVGAnimatedPreserveAspectRatio

• Component: SVG
• Status: RESOLVED FIXED

[Said Abou-Hallawa]

This is very similar to https://bugs.webkit.org/show_bug.cgi?id=195949. The changes should be almost the same expect the animation function for SVGRect is additive while it is discrete for SVGPreserveAspectRatio.

[Said Abou-Hallawa]

Created attachment 365205 [details]
Patch

[Said Abou-Hallawa]

Created attachment 365208 [details]
Patch for review

[Simon Fraser (smfr)]

Comment on attachment 365208 [details]
Patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=365208&action=review

> Source/WebCore/ChangeLog:12
> +        -- Define SVGAnimatedPreserveAspectRatio to be SVGAnimatedValueProperty<
> +           SVGPreserveAspectRatio>.
> +
> +        -- Make SVGPreserveAspectRatio be derived form SVGValueProperty<S
> +           VGPreserveAspectRatioValue>.

Bad wrapping.

> Source/WebCore/svg/properties/SVGAnimatedPropertyAnimatorImpl.h:84
> +        return std::unique_ptr<SVGAnimatedPreserveAspectRatioAnimator>(new SVGAnimatedPreserveAspectRatioAnimator(attributeName, animated, animationMode, calcMode, isAccumulated, isAdditive));

make_unique<>

[Said Abou-Hallawa]

Created attachment 365279 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 365279 [details]
Patch

Clearing flags on attachment: 365279

Committed r243185: <https://trac.webkit.org/changeset/243185>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49045550>