Bug 195957

Summary: Adopt RegistrableDomain in the Storage Access API prompt code paths
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 195866    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Brent Fulgham 2019-03-19 11:22:17 PDT 
While making the code changes in Bug 195866 we noticed that strings were being used to pass the origins for the API calls. We should adopt the RegistrableDomain class to improve type safety and avoid introducing bugs in the future.
Comment 1 Radar WebKit Bug Importer 2019-03-19 20:30:12 PDT 
<rdar://problem/49048028>
Comment 2 Brent Fulgham 2019-03-19 20:35:30 PDT 
Created attachment 365298 [details]
Patch
Comment 3 Brent Fulgham 2019-03-20 08:57:47 PDT 
Created attachment 365348 [details]
Patch
Comment 4 Brent Fulgham 2019-03-20 09:17:19 PDT 
Comment on attachment 365348 [details]
Patch

Thanks for reviewing!
Comment 5 WebKit Commit Bot 2019-03-20 09:41:21 PDT 
Comment on attachment 365348 [details]
Patch

Clearing flags on attachment: 365348

Committed r243210: <https://trac.webkit.org/changeset/243210>
Comment 6 WebKit Commit Bot 2019-03-20 09:41:23 PDT 
All reviewed patches have been landed.  Closing bug.