Bug 195957

Summary: Adopt RegistrableDomain in the Storage Access API prompt code paths
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 195866    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Brent Fulgham
Reported 2019-03-19 11:22:17 PDT
While making the code changes in Bug 195866 we noticed that strings were being used to pass the origins for the API calls. We should adopt the RegistrableDomain class to improve type safety and avoid introducing bugs in the future.
Attachments
Patch (16.42 KB, patch)
2019-03-19 20:35 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (16.54 KB, patch)
2019-03-20 08:57 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-03-19 20:30:12 PDT
<rdar://problem/49048028>
Brent Fulgham
Comment 2 2019-03-19 20:35:30 PDT
Created attachment 365298 [details] Patch
Brent Fulgham
Comment 3 2019-03-20 08:57:47 PDT
Created attachment 365348 [details] Patch
Brent Fulgham
Comment 4 2019-03-20 09:17:19 PDT
Comment on attachment 365348 [details] Patch Thanks for reviewing!
WebKit Commit Bot
Comment 5 2019-03-20 09:41:21 PDT
Comment on attachment 365348 [details] Patch Clearing flags on attachment: 365348 Committed r243210: <https://trac.webkit.org/changeset/243210>
WebKit Commit Bot
Comment 6 2019-03-20 09:41:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.