Bug 195956

Summary: [CMake] Support more clang and gcc sanitizers
Product: WebKit Reporter: Christopher Reid <chris.reid>
Component: CMakeAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, don.olmstead, jbedard, mcatanzaro, ross.kirsling, stephan.szabo, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Christopher Reid 2019-03-19 11:21:29 PDT
WebKitCompilerFlags.cmake currently only supports asan. We should support compiling with other sanitizers like ubsan, thread, memory, and leak.
Comment 1 Christopher Reid 2019-03-19 13:48:06 PDT
Created attachment 365222 [details]
Patch
Comment 2 Christopher Reid 2019-03-19 14:00:32 PDT
Created attachment 365227 [details]
Patch
Comment 3 Michael Catanzaro 2019-03-19 14:09:25 PDT
Comment on attachment 365227 [details]
Patch

Please check Tools/Scripts and fix up any existing uses of ENABLE_ADDRESS_SANITIZER there. We have e.g. set-webkit-configuration --asan that will be broken by this change.
Comment 4 Christopher Reid 2019-03-19 15:31:19 PDT
Created attachment 365243 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-03-19 16:34:09 PDT
Comment on attachment 365243 [details]
Patch for landing

Clearing flags on attachment: 365243

Committed r243179: <https://trac.webkit.org/changeset/243179>
Comment 6 WebKit Commit Bot 2019-03-19 16:34:10 PDT
All reviewed patches have been landed.  Closing bug.