Summary: | Remove the SVG property tear off objects of SVGAnimatedRect | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||||||||||||
Component: | SVG | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, rniwa, simon.fraser, webkit-bug-importer, zimmermann | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Bug Depends on: | 195863 | ||||||||||||||||||
Bug Blocks: | 191237, 195960 | ||||||||||||||||||
Attachments: |
|
Description
Said Abou-Hallawa
2019-03-19 09:45:48 PDT
Created attachment 365174 [details]
Patch
Comment on attachment 365174 [details] Patch Attachment 365174 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11567502 New failing tests: svg/stroke/animated-non-scaling-stroke.html imported/mozilla/svg/as-image/background-resize-4.html Created attachment 365185 [details]
Archive of layout-test-results from ews102 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 365174 [details] Patch Attachment 365174 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11568205 New failing tests: svg/stroke/animated-non-scaling-stroke.html imported/mozilla/svg/as-image/background-resize-4.html Created attachment 365195 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 365174 [details] Patch Attachment 365174 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11567948 New failing tests: svg/stroke/animated-non-scaling-stroke.html imported/mozilla/svg/as-image/background-resize-4.html Created attachment 365197 [details]
Archive of layout-test-results from ews115 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 365199 [details]
Patch
Created attachment 365207 [details]
Patch for review
Comment on attachment 365199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365199&action=review > Source/WebCore/ChangeLog:22 > + SVGAnimatedValueProperty will be responsible of: responsible for > Source/WebCore/svg/properties/SVGAnimatedPropertyAnimatorImpl.h:84 > + return std::unique_ptr<SVGAnimatedRectAnimator>(new SVGAnimatedRectAnimator(attributeName, animated, animationMode, calcMode, isAccumulated, isAdditive)); std::make_unique. Seeing a 'new' in the code should ring alarm bells. Created attachment 365263 [details]
Patch
Comment on attachment 365199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365199&action=review >> Source/WebCore/ChangeLog:22 >> + SVGAnimatedValueProperty will be responsible of: > > responsible for Fixed. >> Source/WebCore/svg/properties/SVGAnimatedPropertyAnimatorImpl.h:84 >> + return std::unique_ptr<SVGAnimatedRectAnimator>(new SVGAnimatedRectAnimator(attributeName, animated, animationMode, calcMode, isAccumulated, isAdditive)); > > std::make_unique. Seeing a 'new' in the code should ring alarm bells. std::make_unique is now used. But I had to make the constructor of this class and its base class be public. Comment on attachment 365263 [details] Patch Clearing flags on attachment: 365263 Committed r243183: <https://trac.webkit.org/changeset/243183> All reviewed patches have been landed. Closing bug. |