| Summary: | Simplify Cocoa platform user agent logic by using string constants instead of function calls for the frozen parts | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Maciej Stachowiak <mjs> | ||||||||
| Component: | New Bugs | Assignee: | Maciej Stachowiak <mjs> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dino, ews-watchlist, rniwa, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Maciej Stachowiak
2019-03-18 23:06:58 PDT
Created attachment 365134 [details]
Patch
Comment on attachment 365134 [details] Patch Attachment 365134 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11560333 New failing tests: http/tests/security/cross-origin-worker-indexeddb.html http/tests/security/cross-origin-indexeddb.html Created attachment 365141 [details]
Archive of layout-test-results from ews113 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 365134 [details] Patch Attachment 365134 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11561087 New failing tests: imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html Created attachment 365143 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
It's hard to see how these changes could cause these particular test failures. And it looks like other unrelated patches have been experiencing the same failures, including these which do not even materially affect the Mac port: https://bugs.webkit.org/attachment.cgi?id=365157&action=prettypatch https://bugs.webkit.org/attachment.cgi?id=365154&action=prettypatch https://bugs.webkit.org/attachment.cgi?id=365152&action=prettypatch So I think the failures are a problem with EWS, or latent flaky crashes. Committed r243187: <https://trac.webkit.org/changeset/243187> |