| Summary: | [WPE] Fix build warnings because of missing an argument when initializing wpe_input_axis_event | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||
| Component: | WPE WebKit | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aperez, bugs-noreply, cgarcia, commit-queue, mcatanzaro, zan | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 365118 [details]
Patch
If 0 is a wrong value for the modifier, please let me know. Comment on attachment 365118 [details]
Patch
Patch LGTM → informal r+
Thanks Adrian and Michael! Comment on attachment 365118 [details] Patch Clearing flags on attachment: 365118 Committed r243184: <https://trac.webkit.org/changeset/243184> All reviewed patches have been landed. Closing bug. |
There are still build warning when building wpe port. I think that these build warnings have been caused by missing to set an argument for the modifier parameter of wpe_input_axis_event. /home/gyuyoung/LGE/starfish/webkit/WebKit/Source/WebKit/UIProcess/API/wpe/ScrollGestureController.cpp: In member function ‘bool WebKit::ScrollGestureController::handleEvent(const wpe_input_touch_event_raw*)’: /home/gyuyoung/LGE/starfish/webkit/WebKit/Source/WebKit/UIProcess/API/wpe/ScrollGestureController.cpp:59:13: warning: missing initializer for member ‘wpe_input_axis_event::modifiers’ [-Wmissing-field-initializers] }; ^ /home/gyuyoung/LGE/starfish/webkit/WebKit/Source/WebKit/UIProcess/API/wpe/ScrollGestureController.cpp:71:13: warning: missing initializer for member ‘wpe_input_axis_event::modifiers’ [-Wmissing-field-initializers] };