| Summary: | REGRESSION(r243058): [GStreamer] 3 tests now timing out | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
| Component: | Media | Assignee: | Philippe Normand <pnormand> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | calvaris, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Philippe Normand
2019-03-18 08:45:11 PDT
Regressions: Unexpected timeouts (3) http/tests/media/video-play-stall-seek.html [ Timeout ] http/wpt/fetch/dnt-header-after-redirection.html [ Timeout ] imported/w3c/web-platform-tests/resource-timing/resource_initiator_types.html [ Timeout ] Created attachment 365016 [details]
Patch
Comment on attachment 365016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365016&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:291 > + mutable uint64_t m_networkReadPosition { 0 }; Do you need this variable to be mutable as well? Comment on attachment 365016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365016&action=review >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:291 >> + mutable uint64_t m_networkReadPosition { 0 }; > > Do you need this variable to be mutable as well? It is not. Good catch! Committed r243140: <https://trac.webkit.org/changeset/243140> |