Bug 195871

Summary: Structure::flattenDictionary() should clear unused property slots.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, keith_miller, msaboff, rmorisset, rniwa, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. msaboff: review+

Description Mark Lam 2019-03-17 20:00:11 PDT
It current attempts to do this but fails because it's actually clearing up the preCapacity region instead.

<rdar://problem/48959497>
Comment 1 Mark Lam 2019-03-17 20:04:29 PDT
Created attachment 364996 [details]
proposed patch.
Comment 2 Michael Saboff 2019-03-18 07:38:46 PDT
Comment on attachment 364996 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=364996&action=review

r=me after addressing ChangeLog wording.

> Source/JavaScriptCore/ChangeLog:9
> +        It current attempts to do this but fails because it's actually clearing up the

Should this read *currently* ?

> Source/JavaScriptCore/ChangeLog:10
> +        preCapacity region instead.  The fix i simply to account for the preCapacity

Should this read "The fix is simply to ..."?
Comment 3 Mark Lam 2019-03-18 09:18:50 PDT
Thanks for the review.  I've fixed the typos.  Landed in r243069: <http://trac.webkit.org/r243069>.