Bug 195860

Summary: Fix WPE and GTK Debug builds after r243049
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Diego Pino
Reported 2019-03-17 04:26:21 PDT
Fix WPE and GTK Debug builds after r243049
Attachments
Patch (1.28 KB, patch)
2019-03-17 04:27 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2019-03-17 04:27:53 PDT
Created attachment 364962 [details] Patch
WebKit Commit Bot
Comment 2 2019-03-17 05:06:54 PDT
Comment on attachment 364962 [details] Patch Clearing flags on attachment: 364962 Committed r243052: <https://trac.webkit.org/changeset/243052>
WebKit Commit Bot
Comment 3 2019-03-17 05:06:55 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-03-17 05:08:57 PDT
<rdar://problem/48961043>
Mark Lam
Comment 5 2019-03-17 18:05:38 PDT
Comment on attachment 364962 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364962&action=review > Source/JavaScriptCore/runtime/StringPrototype.cpp:1822 > + default: > + ASSERT_NOT_REACHED(); How can this be possibly be correct? Normalization form is an enum class with only the above four values. Can you please provide details on what the WPE and GTK Debug builds errors are? This patch would have be r-ed under normal circumstances.
Note You need to log in before you can comment on or make changes to this bug.